View source for Module talk:WikidataIB

{{Permanently protected}}
{{WPBS|
{{WikiProject Wikidata}}
}}
{{banner holder|text=Page history|1=
{{oldtfdfull|date= 2020 September 15 |result=keep |disc=Module:Wikidata Infobox}}
}}
{{to-do|collapsed=yes}}
{{archives|search=yes}}
{{User:MiszaBot/config
|archiveheader       = {{talkarchivenav}}
|maxarchivesize      = 75K
|counter             = 8
|minthreadsleft      = 3
|minthreadstoarchive = 1
|algo                = old(60d)
|archive             = Module talk:WikidataIB/Archive %(counter)d
}}

== getValueByRefSource  ==

There are no examples for getValueByRefSource... What I'm after is the population (P1082) of Toronto ([[wikidata:Q172#P1082|Q172]]), as given by the 2021 Canadian Census (Q42317745). The data is there, and I'm trying to access it with the following:
:<nowiki>{{#invoke:WikidataIB |getValueByRefSource |qid=Q172 | P1082 |match=Q42317745 |fwd=ALL}}</nowiki>

... which doesn't return anything, not even an error message. What am I missing  here? [[User:Tompw|Tom<small>pw</small>]] ([[User talk:Tompw|talk]]) 19:14, 11 November 2025 (UTC)

:Hmmmm. The documented way it works is that getValueByRefSource will only return a value if Toronto's property for {{q|P1082}} has sub property {{q|P248}} filled in. Toronto does not on the {{q|Q42317745 }} ref so your code won't work, earlier years do but it won't pull those back when I change the code - the plot thickens, it seems to only return values when a very specific qualifier is used, in this case only if {{q|Q21540096}} or {{q|Q7804 }} is quoted, such as on [[d:Q28#P2131|Q28]] or [[d:Q100874038#P2131|Q100874038]], and amounts in dollars.
:Full list using those qualifiers is [https://w.wiki/H956 here.] Only around 200 articles satisfy the requirement. The module looks to have some hardcoded values in amongst the <code>getValueByRefSource</code> function code {{q|Q21540096}} and {{q|Q4917}}, and looks to have been added during testing back in 2018 [https://en.wikipedia.org/wiki/Module_talk:WikidataIB/Archive_3#Retrieve_value_by_source here.] The returned figures are also being truncated, and it's not clear whether to use |qvalue= or |match= to input the qualifier but they are returning different amounts.
:@[[User:Tompw|Tompw]] If you instead use <syntaxhighlight lang="wikitext" inline>{{#invoke:WikidataIB |getValue  |qid=Q172 | P1082  |ps=3}}</syntaxhighlight> that should fetch the data you need for now.
:@[[User:Pigsonthewing|Pigsonthewing]] @[[User:Jonesey95|Jonesey95]], as recent editors could you check the above thanks, I added some test cases in [[Module:WikidataIB/sandbox]]. Regs, [[User:The Equalizer|The Equalizer]] ([[User talk:The Equalizer|talk]]) 01:04, 22 December 2025 (UTC)
::No idea. I find this module's options, when combined with the jargon used on Wikidata, nearly impenetrable. I just keep trying things until it sometimes work. I give up about half the time. – [[User:Jonesey95|Jonesey95]] ([[User talk:Jonesey95|talk]]) 02:19, 22 December 2025 (UTC)

== Edit request 14 November 2025 ==

{{Edit template-protected|answered=yes}}

'''Description of suggested change:''' Please apply [[c:Special:Diff/1115600336]] to fix the order of "mul" in the language fallback sequence for labels (should be after all explicit fallbacks, but just before the implicit fallback to "en").

'''Diff:'''
{{Text diff
|1=
local fbtbl = mw.language.getFallbacksFor( args.lang )
table.insert( fbtbl, 1, args.lang )
table.insert( fbtbl, 1, "mul" )
|2=
local fbtbl = mw.language.getFallbacksFor( args.lang, mw.language.FALLBACK_STRICT )
table.insert( fbtbl, 1, args.lang )
table.insert( fbtbl, "mul" )
table.insert( fbtbl, "en" )
}}
[[User:Lucas Werkmeister|Lucas Werkmeister]] ([[User talk:Lucas Werkmeister|talk]]) 19:59, 14 November 2025 (UTC)

:[[User:Lucas Werkmeister|Lucas Werkmeister]], this change is now in the sandbox: [[Special:Diff/1317055591/1325225748]]. I'm not familiar with this module. Which templates use it? Is there a good way to test it? What problem visible in usages of this module does it solve? —⁠[[User:Andrybak|andrybak]] ([[User talk:Andrybak|talk]]) 22:06, 1 December 2025 (UTC)
::@[[User:Andrybak|Andrybak]]: It took a while to put together a working demo (because only such a small part of the module actually uses <code>mul</code> labels at the moment – it should probably be used in more places, using the correct version of the fallback code), but here’s one: [[User:Lucas Werkmeister/sandbox]] ([[Special:Permalink/1325240674]]). The statement shown is {{Q|Q532240}} | {{Q|P3618}}, which is a quantity with the unit {{Q|Q199471}}, and that unit has two [[:d:Property:P5061|unit symbols]]: <q lang=en>Afs</q> in English and <q lang=mul>؋</q> in <code>mul</code> (the Pashto sign). The old code is incorrectly displaying the <code>mul</code> symbol rather than the English symbol. [[User:Lucas Werkmeister|Lucas Werkmeister]] ([[User talk:Lucas Werkmeister|talk]]) 23:45, 1 December 2025 (UTC)

{{done}}—Please report any issues. <span class="vcard"><span class="fn">[[User:Pigsonthewing|Andy Mabbett]]</span> (<span class="nickname">Pigsonthewing</span>); [[User talk:Pigsonthewing|Talk to Andy]]; [[Special:Contributions/Pigsonthewing|Andy's edits]]</span> 14:19, 8 December 2025 (UTC)

:{{ping|Pigsonthewing|Lucas Werkmeister}} I '''might''' have found a bug in this recent change. Two lighthouse pages had units of type {{code|M}} showing up. See these permalinks:
:* [https://en.wikipedia.org/w/index.php?title=Abu_Musa&oldid=1326363482 Abu Musa]
:* [https://en.wikipedia.org/w/index.php?title=Lindisfarne&oldid=1326267476 Lindisfarne]
:And look specifically at the '''Range''' values in the infobox. I went down the rabbit hole for both pages (which showed up in [[:Category:Convert errors]]) and the ONLY relevant change I could find was to this module (no updates to wikidata, the articles themselves, {{tl|Infobox lighthouse}}, etc.) 
:Now the '''temporary''' fix was to manually use {{tl|convert}} on those pages... But that removes the call to wikidata and seems to be indicative of a larger problem. I would encourage a revert of the recent change that was made. '''[[User:Zackmann08|<span style="color:#00ced1">Zack</span><span style="color:#007F94">mann</span>]]''' (<sup>[[User_talk:Zackmann08|Talk to me]]</sup>/<sub>[[Special:Contributions/Zackmann08|<span style="color:orange;">What I been doing</span>]]</sub>) 17:34, 8 December 2025 (UTC)
::Thank you. Reverted. <span class="vcard"><span class="fn">[[User:Pigsonthewing|Andy Mabbett]]</span> (<span class="nickname">Pigsonthewing</span>); [[User talk:Pigsonthewing|Talk to Andy]]; [[Special:Contributions/Pigsonthewing|Andy's edits]]</span> 17:36, 8 December 2025 (UTC)
:::Well that was insanely quick... Thanks Andy! '''[[User:Zackmann08|<span style="color:#00ced1">Zack</span><span style="color:#007F94">mann</span>]]''' (<sup>[[User_talk:Zackmann08|Talk to me]]</sup>/<sub>[[Special:Contributions/Zackmann08|<span style="color:orange;">What I been doing</span>]]</sub>) 17:37, 8 December 2025 (UTC)
::::@[[User:Zackmann08|Zackmann08]], @[[User:Pigsonthewing|Pigsonthewing]]: I don’t think that was a bug? {{Q|Q93318}} has three English “unit symbol” statements and they all have the same rank. [[User:Lucas Werkmeister|Lucas Werkmeister]] ([[User talk:Lucas Werkmeister|talk]]) 19:32, 8 December 2025 (UTC)
:::::{{ping|Lucas Werkmeister}} I'm not very good with Wikidata... All I know is that the 2 pages I linked to above were displaying an error because {{tl|convert}} was trying to convert with unit type {{code|M}} as shown here:
:::::* {{convert|4|M}}
:::::Exactly why this is happening, I'm not sure... But it was pretty clearly directly related to the change that was implemented. '''[[User:Zackmann08|<span style="color:#00ced1">Zack</span><span style="color:#007F94">mann</span>]]''' (<sup>[[User_talk:Zackmann08|Talk to me]]</sup>/<sub>[[Special:Contributions/Zackmann08|<span style="color:orange;">What I been doing</span>]]</sub>) 19:42, 8 December 2025 (UTC)
::::::I see, that sounds like a more serious error than what I expected, at least (I thought it just displayed the symbol as M instead). Plugging a Wikidata unit symbol into {{tl|convert}} doesn’t sound like the greatest idea to me (the item ID of the unit would be a much more stable identifier), but that would be a larger change.
::::::Looking at the code more closely… I think it’s badly broken anyway? I assume the <em>intention</em> is to follow the language fallback chain and find the first unit symbol statement with a language code matching the target language, or the target language’s first fallback, or its second fallback, and so on. But in fact, the structure of the loops means that, for the most part, it’ll find the first unit symbol statement whose language code appears <em>anywhere</em> in the language fallback chain? <em>Except</em> that there’s also another bug where the <code>if found then break end</code> is, if I’m not mistaken, placed one line above where it should be, with the result that it never breaks out of the outer loop, and therefore it actually returns the <em>last</em> statement where the language code appears anywhere in the fallback chain?
::::::I still haven’t worked out why the requested edit made a difference, though. I think it would’ve changed the <code>fbtbl</code> from <code>{"mul", "en", "en"}</code> to <code>{"en", "mul", "en"}</code> (assuming that, in the context of those pages, <code>args.lang</code> is <code>"en"</code>), but why did that change the result… [[User:Lucas Werkmeister|Lucas Werkmeister]] ([[User talk:Lucas Werkmeister|talk]]) 20:15, 8 December 2025 (UTC)
:::::::Oh, apparently the old code resulted in <code>{"mul", "en"}</code> instead (no second <code>"en"</code> as I expected). [[User:Lucas Werkmeister|Lucas Werkmeister]] ([[User talk:Lucas Werkmeister|talk]]) 20:21, 8 December 2025 (UTC)
:::::::: {{ping|Pigsonthewing}} Please consider retrying the edit request with [[Special:Diff/1326419389]] applied on top; as far as I can tell from trying out the Lua snippets at [[Special:Permalink/1326419901]] in the debug console, that should work better. (But you, unlike me, should be able to try it out using the “preview page with this template” feature, to make sure that Abu Musa and Lindisfarne don’t regress again.) --[[User:Lucas Werkmeister|Lucas Werkmeister]] ([[User talk:Lucas Werkmeister|talk]]) 22:08, 8 December 2025 (UTC)
:::::::::I suggest sandboxing your code and use some test cases to verify it works &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 15:10, 9 December 2025 (UTC)
::::::::::Agree. <span class="vcard"><span class="fn">[[User:Pigsonthewing|Andy Mabbett]]</span> (<span class="nickname">Pigsonthewing</span>); [[User talk:Pigsonthewing|Talk to Andy]]; [[Special:Contributions/Pigsonthewing|Andy's edits]]</span> 15:36, 9 December 2025 (UTC)
:::::::::::What do you mean, “my code”? This isn’t my module. And I <em>did</em> extract the code as far as possible and tested it, that’s what you’re seeing on [[Special:Permalink/1326419901]]. [[User:Lucas Werkmeister|Lucas Werkmeister]] ([[User talk:Lucas Werkmeister|talk]]) 17:44, 9 December 2025 (UTC)
::::::::::::Sorry, I think I misunderstood what you meant and overreacted… I thought “sandboxing” meant you were expecting me to refactor the whole module (some 3500 lines long) to make it more testable in isolation. I’m now guessing you meant putting the code into the /sandbox subpage (I wasn’t aware of such a meaning of “sandbox” as a verb before, but then I don’t move around much in the technical namespaces of enwiki).
::::::::::::But I’ve done that, haven’t I? I’ve updated the /sandbox page again, and my previous test case at [[Special:Permalink/1325240674]] still behaves correctly with the improved sandbox code; it’s unclear to me how I’m supposed to test the error reported at Abu Mus and Lindisfarne (how do you “thread” the /sandbox usage through X layers of intermediate templates?), but I tested that situation in isolation at [[Special:Permalink/1326419901]] and as far as I can tell the new version ought to behave correctly there. I don’t know what else I’m supposed to test without having access to the “preview page with this template” feature, which ought to make it trivial for the person fulfilling the edit request to check how Abu Mus and Lindisfarne behave with the new version. [[User:Lucas Werkmeister|Lucas Werkmeister]] ([[User talk:Lucas Werkmeister|talk]]) 18:10, 9 December 2025 (UTC)

{{od}}
I assume Martin was referring to your comment: {{Tq|1="But you, unlike me, should be able to try it out using the “preview page with this template” feature, to make sure that Abu Musa and Lindisfarne don’t regress again."}}

It's normal that the person requesting the change tests it before-hand. <span class="vcard"><span class="fn">[[User:Pigsonthewing|Andy Mabbett]]</span> (<span class="nickname">Pigsonthewing</span>); [[User talk:Pigsonthewing|Talk to Andy]]; [[Special:Contributions/Pigsonthewing|Andy's edits]]</span> 19:16, 9 December 2025 (UTC)

:I understand that, but what I keep trying to say is that I believe I’ve tested the change as much as I reasonably can, and you ought to be able to further test it in a way that I’m simply unable to. [[User:Lucas Werkmeister|Lucas Werkmeister]] ([[User talk:Lucas Werkmeister|talk]]) 20:59, 9 December 2025 (UTC)
:: (Reactivating the edit request as there’s been no response for while and I would still like the edit to be made.) --[[User:Lucas Werkmeister|Lucas Werkmeister]] ([[User talk:Lucas Werkmeister|talk]]) 11:40, 27 December 2025 (UTC)
::: {{done}}<!-- Template:ETp --> [[User:taavi|taavi]] ([[User talk:Taavi|talk!]]) 11:47, 27 December 2025 (UTC)
::::Thank you! Let’s hope it works better this time. [[User:Lucas Werkmeister|Lucas Werkmeister]] ([[User talk:Lucas Werkmeister|talk]]) 17:37, 27 December 2025 (UTC)

== Use in redirect targets ==

[[Template:infobox quantity]] retrieves the [[quantity dimension]] from a Wikidata property. I'm using it in article section [[Magnetic field#The H-field]] which corresponds to {{Q|28123}} via redirect [[H-field]]. Is there a way to indicate the Q-item for the template? [[User:Fgnievinski|fgnievinski]] ([[User talk:Fgnievinski|talk]]) 01:49, 22 May 2026 (UTC)